Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scroll Cursor Visible While Typing #55

Merged
merged 1 commit into from
Nov 10, 2024
Merged

Scroll Cursor Visible While Typing #55

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions Sources/CodeEditTextView/TextView/TextView+ReplaceCharacters.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,12 @@ extension TextView {
layoutManager.endTransaction()
selectionManager.notifyAfterEdit()
NotificationCenter.default.post(name: Self.textDidChangeNotification, object: self)

// `scrollSelectionToVisible` is a little expensive to call every time. Instead we just check if the first
// selection is entirely visible. `.contains` checks that all points in the rect are inside.
if let selection = selectionManager.textSelections.first, !visibleRect.contains(selection.boundingRect) {
scrollSelectionToVisible()
}
}

/// Replace the characters in a range with a new string.
Expand Down
Loading