Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: change method to type on Zendesk requests #55

Merged
merged 2 commits into from
Oct 23, 2023
Merged

feat: change method to type on Zendesk requests #55

merged 2 commits into from
Oct 23, 2023

Conversation

JoaoMacedo03
Copy link
Contributor

Description:
Replace the non-existent "method" property in the Zendesk request with the correct property, "type", for methods other than GET.

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Why is this change required?:
This error prevents requests other than GET from being executed using the library.

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@JoaoMacedo03 JoaoMacedo03 requested a review from a team October 23, 2023 19:07
larissajuliavsa
larissajuliavsa approved these changes Oct 23, 2023
View reviewed changes
Copy link

@larissajuliavsa larissajuliavsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aprovado!

@JoaoMacedo03 JoaoMacedo03 merged commit 326e19e into main Oct 23, 2023
@github-actions github-actions bot deleted the fix/change-method-to-type-zendesk branch October 23, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larissajuliavsa larissajuliavsa larissajuliavsa approved these changes

Assignees

@JoaoMacedo03 JoaoMacedo03

Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoaoMacedo03 @larissajuliavsa