Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce default timeout to 10 seconds #575

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

SadPencil
Copy link
Member

@SadPencil SadPencil commented Oct 15, 2024

The web client was created by new WebClient() without assigning a timeout value. It seems that the default timeout value is undocumented, and the debugger told me the default value is 100000 ms (note: 100 seconds!) No wonder why some people with poor Internet condition complained about it takes too long to wait for their clients to initialize.

This PR proposed the following changes:

  • By default, the timeout value would be 10 seconds instead of 100 seconds
  • As an exception, the timeout value of uploading/downloading a map is set to 100 seconds
  • Remove the obsolete TWebClient introduced 8 years ago (here) since ExtendedWebClient was introduced 6 years ago (here)
  • Remove the weird statement webClient.Proxy = null introduced 8 years ago (here). Since now WebClients are initialized everywhere and no one explicitly clear the proxy setting like here, removing this statement will make the client behaves consistently -- leaving the proxy setting as system default.

@SadPencil SadPencil added this to the 2.11.2.0 milestone Oct 15, 2024
Copy link

github-actions bot commented Oct 15, 2024

Nightly build for this pull request:

@ismail-doitbig
Copy link

Sorry this might be off topic but I noticed a bunch of trollers on purpose disconnect their cable for two seconds and then reconnect again, they do this until everyone votes to kick them or people just leave because it's too annoying..

Can something be done about this?

E.g. If the cumulative delay is 10s over a 60s time period the person should be kicked so trollers that disconnect 3 seconds each, after the 4th time will get autokicked

If this is possible I would be forever thankful!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants