Adapt hawk_test code to support testing for 12-SP2 #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MalloZup
reviewed
Aug 25, 2020
MalloZup
approved these changes
Aug 25, 2020
MalloZup
reviewed
Aug 25, 2020
| if Version(self.test_version) < Version("12-SP3"): | ||
| click_list.remove(Xpath.HREF_FENCING) | ||
|
|
||
| self.check_and_click_by_xpath("while checking around edit configuration", click_list) |
There was a problem hiding this comment.
while checking around is a bit to much familiar but I guess is ok, 😁
MalloZup
approved these changes
Aug 25, 2020
|
@ricardobranco777 can you send a PR to https://github.com/ClusterLabs/hawk/blob/master/doc/release.md |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapt hawk_test code to support testing for 12-SP2
Also fix Dockerfile for best & recommended practices (avoid consecutive RUN's that increase image size).