-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use java 23 #1507
Merged
chore: use java 23 #1507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derklaro
added
s: blocked
Please do not merge, the pull request is not ready yet / waiting for something which is required
v: 4.X
This pull should be included in the 4.0 release
labels
Sep 15, 2024
Test Results 48 files ±0 48 suites ±0 1m 39s ⏱️ -25s Results for commit 362c602. ± Comparison against base commit e392bbb. This pull request removes 32 and adds 32 tests. Note that renamed tests count towards both.
|
derklaro
removed
the
s: blocked
Please do not merge, the pull request is not ready yet / waiting for something which is required
label
Oct 10, 2024
0utplay
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Java 23 will release at September 17, 2024. As we're cuirrently running on the STS version 22 we need to update as soon as possible.
Modification
Update all build scripts and code to use java 23, fix some issues with preview api that has changed.
Result
Java 23 is used for CloudNet instead of java 22.