This repository has been archived by the owner on May 5, 2022. It is now read-only.
propagate tracer for async code #44
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdams
reviewed
Sep 24, 2018
lib/namespace.js
Outdated
| @@ -0,0 +1,31 @@ | |||
| 'use strict'; | |||
|
|
|||
| const asyncHooks = require('async_hooks'); | |||
There was a problem hiding this comment.
async_hooks was only added to core in Node 8 and above. This is going to cause issues on Node 6
|
@gdams I have added conditionals to use async_hooks only for node 8 and above.. So the problem will be resolved for node 8 and above... but will still exist for node 6. The tests pass on node 6, 8, current(10). I guess this is not a breaking change now, but only fixes it on certain versions |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an underlying issue with using zipkin-context-cls. There are open PRs that claim to resolve this but they are not merged and pulling the change locally did not work for me.
resolves #43
resolves #40
Tests pass locally on Mac.