Merge pull request #2635 from Clinical-Genomics/polish_str_filter

chr pos split js safer for STR view

CHANGELOG.md

@@ -35,6 +35,7 @@ About changelog [here](https://keepachangelog.com/en/1.0.0/)
 - Old STR causatives (and other variants) may not have HGNC symbols - fix sort lambda
 - Check if gene_obj has primary_transcript before trying to access it
 - Warn if a gene manually searched is in a clinical panel with an outdated name when filtering variants
+- ChrPos split js not needed on STR page yet
 ### Changed
 - Remove parsing of case `genome_version`, since it's not used anywhere downstream
 - Introduce deprecation warning for Loqus configs that are not dictionaries

scout/server/blueprints/variants/static/form_scripts.js

@@ -2,7 +2,11 @@
 function populateCytobands(cytobands){
   var chromPosPattern = new RegExp("^(?:chr)?([1-9]|1[0-9]|2[0-2]|X|Y|MT)$");
   var chrom = document.forms["filters_form"].elements["chrom"].value;
-  var chromPos = document.forms["filters_form"].elements["chrom_pos"].value;
+  var chromPos = "";
+  if (typeof document.forms["filters_form"].elements["chrom_pos"] !== "undefined") {
+  	chromPos=document.forms["filters_form"].elements["chrom_pos"].value;
+	}
+
   var chromosome = "";
   console.log("Populate cytobands")
   var matchedChrName = chromPos.match(chromPosPattern)

scout/server/blueprints/variants/templates/variants/str-variants.html

@@ -152,7 +152,6 @@
 
     window.onload=function() {
       populateCytobands({{cytobands|safe}});
-
       {{ update_stash_filter_button_status(current_user, filters) }}
     }