Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watchmaker EPP updates #536

Merged
merged 7 commits into from
Oct 3, 2024
Merged

Watchmaker EPP updates #536

merged 7 commits into from
Oct 3, 2024

Conversation

Karl-Svard
Copy link
Collaborator

@Karl-Svard Karl-Svard commented Sep 27, 2024

Added

  • New flag to specify max volume in the calculate volume-buffer EPP

Changed

  • Renamed the TWIST aliquot amount EPP to just "aliquot-amount"
  • Also generalized it by moving all hard-coded UDF names and constants to click options instead

Steps to consider while deploying

  • Configuration changes:
  • Documentation updates:
  • Inform users by email:

Review:

  • Code approved by
  • Tests executed on stage by: (Document the test done with screen shots and description.)
  • "Merge and deploy" approved by

This version is a:

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@Karl-Svard
Copy link
Collaborator Author

Karl-Svard commented Oct 1, 2024

Aliquot amount EPP worked on stage for TWIST workflow.

lims -c ../config/genologics-stage.yaml epps -l ../log.log -p 24-553604 udf calculate aliquot-amount -v 'Volume (ul)' --total-volume-udf 'Total Volume (ul)' --concentration-udf 'Concentration' --amount-ng-udf 'Amount needed (ng)' --max-amount 250

https://cg-lims-stage.sys.scilifelab.se/clarity/work-details/553604

@Karl-Svard
Copy link
Collaborator Author

Updates to the calculate volume-buffer tested on stage:

(cg_lims) karl.svard@karlsmbp cg_lims % lims -c ../config/genologics-stage.yaml epps -l ../log.log -p 24-553545 udf calculate volume-buffer -v 'Sample Volume (ul)' -b 'EB Volume (ul)' --total-volume-udf 'Total Volume (uL)' -svl 50 --max-volume 100
Total volume higher than 100 ul for some samples!
(cg_lims) karl.svard@karlsmbp cg_lims % lims -c ../config/genologics-stage.yaml epps -l ../log.log -p 24-553545 udf calculate volume-buffer -v 'Sample Volume (ul)' -b 'EB Volume (ul)' --total-volume-udf 'Total Volume (uL)' -svl 50 --max-volume 110
Volumes have been calculated.
(cg_lims) karl.svard@karlsmbp cg_lims % lims -c ../config/genologics-stage.yaml epps -l ../log.log -p 24-553545 udf calculate volume-buffer -v 'Sample Volume (ul)' -b 'EB Volume (ul)' --total-volume-udf 'Total Volume (uL)' -svl 50 --max-volume 111
Volumes have been calculated.
(cg_lims) karl.svard@karlsmbp cg_lims % lims -c ../config/genologics-stage.yaml epps -l ../log.log -p 24-553545 udf calculate volume-buffer -v 'Sample Volume (ul)' -b 'EB Volume (ul)' --total-volume-udf 'Total Volume (uL)' -svl 50 --max-volume 109
Total volume higher than 109 ul for some samples!
(cg_lims) karl.svard@karlsmbp cg_lims % lims -c ../config/genologics-stage.yaml epps -l ../log.log -p 24-553545 udf calculate volume-buffer -v 'Sample Volume (ul)' -b 'EB Volume (ul)' --total-volume-udf 'Total Volume (uL)' -svl 50 --max-volume 50 
Total volume higher than 50 ul for some samples!

Step used was https://cg-lims-stage.sys.scilifelab.se/clarity/work-complete/553545 where the highest volume is 110ul.

@Karl-Svard Karl-Svard marked this pull request as ready for review October 1, 2024 14:56
Copy link

@AbiDalby AbiDalby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Copy link
Contributor

@idalindegaard idalindegaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks great👏

@Karl-Svard Karl-Svard merged commit e3afad5 into master Oct 3, 2024
2 checks passed
@Karl-Svard Karl-Svard deleted the watchmaker_aliquot branch October 3, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants