Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for 25B and 1.5B flow cells #453

Merged
merged 8 commits into from
Nov 21, 2023
Merged

Conversation

Karl-Svard
Copy link
Collaborator

@Karl-Svard Karl-Svard commented Nov 15, 2023

Added

  • New constants for 25B and 1.5B flow cells
  • New EPP for checking that given process UDFs have been set, cg_lims/EPPs/udf/check/check_process_udfs.py
  • New constants file for the set EPPs, cg_lims/EPPs/udf/set/constants.py
  • New EPP for automatically filling in the default sequencing settings for a given flow cell type, cg_lims/EPPs/udf/set/set_sequencing_settings.py

Changed

  • Reworked the way constants were used in cg_lims/EPPs/udf/calculate/novaseq_x_denaturation.py
  • updated cg_lims/EPPs/udf/calculate/novaseq_x_volumes.py to use the new constants

Steps to consider while deploying

  • Configuration changes:
  • Documentation updates:
  • Inform users by email:

Review:

  • Code approved by
  • Tests executed on stage by: (Document the test done with screen shots and description.)
  • "Merge and deploy" approved by

This version is a:

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@Karl-Svard Karl-Svard marked this pull request as ready for review November 21, 2023 15:47
Copy link
Contributor

@idalindegaard idalindegaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grymt jobbat Kalle! 🔥

@Karl-Svard Karl-Svard merged commit 5222040 into master Nov 21, 2023
2 checks passed
@Karl-Svard Karl-Svard deleted the new_x_flow_cells branch November 21, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants