Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch existing parents in rules #4160

Merged
merged 3 commits into from
Jan 28, 2025
Merged

Patch existing parents in rules #4160

merged 3 commits into from
Jan 28, 2025

Conversation

islean
Copy link
Contributor

@islean islean commented Jan 28, 2025

Description

We have a problem with validating parents when they are existing samples. This PR patches four rules

Added

Changed

Fixed

  • validate_father_in_same_case works with existing samples
  • validate_mother_in_same_case works with existing samples
  • validate_fathers_are_male works with existing samples
  • validate_mothers_are_female works with existing samples

How to prepare for test

  • Ssh to relevant server (depending on type of change)
  • Use stage: us
  • Paxa the environment: paxa
  • Install on stage (example for Hasta):
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_cg -t cg -b [THIS-BRANCH-NAME] -a

How to test

  • Do ...

Expected test outcome

  • Check that ...
  • Take a screenshot and attach or copy/paste the output.

Review

  • Tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Document in ...
  • Deploy this branch on ...
  • Inform to ...

@islean islean requested a review from a team as a code owner January 28, 2025 09:04
@clingen-sthlm clingen-sthlm temporarily deployed to stage January 28, 2025 09:29 Inactive
Copy link
Contributor

@diitaz93 diitaz93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Copy link

Copy link

Please retry analysis of this Pull-Request directly on SonarQube Cloud

@islean islean merged commit 9c71d78 into master Jan 28, 2025
10 checks passed
@islean islean deleted the patch-existing-parents branch January 28, 2025 09:43
@islean
Copy link
Contributor Author

islean commented Jan 28, 2025

Deployed to the VMs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants