Add existing-data tag to ticket #4133
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add parent models and Tomte models for the new validation flow.
Split logic into modules based on workflow
### Fixed - Some typing and a blueprint method for converting pydantic errors to our own custom errors.
### Added - Validation that the provided applications exist in the database
### Added - Check that the application provided is compatible with the chosen workflow.
### Added - Applications are validated not to be archived.
### Fixed - Standardised rule naming.
### Added - Added validation making sure that the gene panels exist in status db
### Added - Adds validation ensuring gene panels are not specified more than once.
### Added - Buffer validation for orders attempting to skip reception control
### Added - Validation ensuring that the subject id is not the same as the case name.
### Added - Validation ensuring that the sample name and subject id can not be the same.
### Added - Validation that the concentration is provided for all samples when skip reception control is attempted.
### Added - Container names are required when using well plates.
### Added - Validation that well position is filled in for samples in a well plate.
### Fixed - Existing cases are forced to be part of the customer's collaboration
### Fixed - Existing samples are enforced to belong to the same collaboration as the customer placing the order.
enhance order submission integration tests
### Fixed - No hard coding of delivery type or workflow in the storing services
### Fixed - The pre commit matches master
### Fixed - MutantSample and MicrosaltSample dumps the verified_organism value
### Fixed - The repeated case name rule only considers new cases
### Fixed - The volume interval is not validated for Pacbio orders since the interval is not what the customers need either way
### Fixed - Panels are optional for existing cases.
add test for validation pool
add tests for mutant validator
2 tasks
|
I do not see why other tests that I haven't touched could be affected but I think you recently changed stuff in there when you have time can you help me understanding what happened? Thanks |
Vince-janv
reviewed
Jan 21, 2025
Vince-janv
reviewed
Jan 21, 2025
|
|
Problem with merging improve-order-flow-main, closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
close #4005
Added
How to prepare for test
uspaxaHow to test
Expected test outcome
Review
Thanks for filling in who performed the code review and the test!
This version is a
Implementation Plan