removing old sample and order models pt 1 #4097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diitaz93
changed the title
diitaz93
commented
Jan 16, 2025
| @@ -7,6 +7,7 @@ | |||
| def is_sample_missing_capture_kit(sample: BalsamicSample, store: Store) -> bool: | |||
| application: Application = store.get_application_by_tag(sample.application) | |||
| return ( | |||
| application.prep_category == SeqLibraryPrepCategory.TARGETED_GENOME_SEQUENCING | |||
| application | |||
There was a problem hiding this comment.
this fixes a bg in the validation, if the application does not exists, the validation breaks
islean
approved these changes
Jan 16, 2025
cg/services/order_validation_service/workflows/balsamic/utils.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Isak Ohlsson Ångnell <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The old validation used pydantic models such as
OrderIn, and samples for each ordertype that new ones have replaced, therefore they need to be deleted. They are still called in many tests set to fail. The tests are still kept as they need to be translated into the new validation. This PR attempts to remove the pydantic models and fix the tests. Many changes are involved, so I separated the PR with an incomplete working set of changes.Added
Changed
Fixed
How to prepare for test
uspaxaHow to test
Expected test outcome
Review
Thanks for filling in who performed the code review and the test!
This version is a
Implementation Plan