(Improve order flow) Clean up the Order model

[islean]

Description

The order model contains several attributes which should not exist. connect_to_ticket should not exist at all and user_id is not set in the form so it should be marked as a private attribute. Closes https://github.com/Clinical-Genomics/improve-order-flow/issues/100

Added

• Tests for the order rules

Changed

Fixed

• connect_to_ticket removed from Order
• user_id is made into a private attribute

How to prepare for test

• Ssh to relevant server (depending on type of change)
• Use stage: us
• Paxa the environment: paxa
• Install on stage (example for Hasta):

  bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_cg -t cg -b [THIS-BRANCH-NAME] -a

How to test

• Do ...

Expected test outcome

• Check that ...
• Take a screenshot and attach or copy/paste the output.

Review

• Tests executed by
• "Merge and deploy" approved by
  Thanks for filling in who performed the code review and the test!

This version is a

• MAJOR - when you make incompatible API changes
• MINOR - when you add functionality in a backwards compatible manner
• PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

• Document in ...
• Deploy this branch on ...
• Inform to ...

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[islean]

Order placed correctly

[diitaz93]

Looks great ⭐