Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add nallo to cg workflow cli #4077

Merged
merged 2 commits into from
Jan 14, 2025
Merged

add nallo to cg workflow cli #4077

merged 2 commits into from
Jan 14, 2025

Conversation

peterpru
Copy link
Member

@peterpru peterpru commented Jan 13, 2025

Description

Add Nallo to cg workflow without any options.

Nallo integration. For sysdev: identical to raredisease PR: #2649 without the alembic part (which is already added in cg for nallo), basically replacing the word raredisease with the word nallo.

Added

  • nallo to cg workflow cli

Changed

Fixed

How to prepare for test

  • Ssh to relevant server (depending on type of change)
  • Use stage: us
  • Paxa the environment: paxa
  • Install on stage (example for Hasta):
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_cg -t cg -b add-nallo-to-cg-workflow

How to test

  • Do cg workflow --help

Expected test outcome

  • Check that nallo is listed among the options.
  • Take a screenshot and attach or copy/paste the output.
image

Review

  • Tests executed by PP
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Document in ...
  • Deploy this branch on ...
  • Inform to ...

@peterpru peterpru self-assigned this Jan 13, 2025
@peterpru peterpru requested a review from a team as a code owner January 13, 2025 20:45
@peterpru peterpru added the nallo label Jan 13, 2025
@peterpru peterpru changed the base branch from nallo-integration to master January 13, 2025 22:04
@diitaz93 diitaz93 self-requested a review January 14, 2025 08:30
Copy link
Contributor

@diitaz93 diitaz93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 🚀

cg/cli/workflow/nallo/base.py Outdated Show resolved Hide resolved
tests/conftest.py Outdated Show resolved Hide resolved
cg/meta/workflow/nallo.py Outdated Show resolved Hide resolved
@peterpru peterpru merged commit b294fc3 into master Jan 14, 2025
10 checks passed
@peterpru peterpru deleted the add-nallo-to-cg-workflow branch January 14, 2025 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants