Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Improve order flow) Fix index validation #4073

Merged
merged 18 commits into from
Jan 14, 2025
Merged

(Improve order flow) Fix index validation #4073

merged 18 commits into from
Jan 14, 2025

Conversation

islean
Copy link
Contributor

@islean islean commented Jan 10, 2025

Description

This PR adds the allowed index sequences to the backend and adds rules for when index_number and index_sequence are required fields for RML and Fluffy orders.

Added

  • Index sequences stored in backend

Changed

Fixed

  • Index validation added

How to prepare for test

  • Ssh to relevant server (depending on type of change)
  • Use stage: us
  • Paxa the environment: paxa
  • Install on stage (example for Hasta): 
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_cg -t cg -b [THIS-BRANCH-NAME] -a

How to test

  • Do ...

Expected test outcome

  • Check that ...
  • Take a screenshot and attach or copy/paste the output.

Review

  • Tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Document in ...
  • Deploy this branch on ...
  • Inform to ...

@islean islean requested a review from a team as a code owner January 10, 2025 15:55
diitaz93
diitaz93 approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@diitaz93 diitaz93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! left some minor comments easy to address

cg/services/order_validation_service/constants.py Outdated Show resolved Hide resolved
cg/services/order_validation_service/errors/sample_errors.py Outdated Show resolved Hide resolved
cg/services/order_validation_service/rules/sample/rules.py Outdated Show resolved Hide resolved
cg/services/order_validation_service/rules/sample/utils.py Show resolved Hide resolved
cg/services/order_validation_service/workflows/rml/models/sample.py Outdated Show resolved Hide resolved
@clingen-sthlm clingen-sthlm temporarily deployed to stage January 13, 2025 09:23 Inactive
@clingen-sthlm clingen-sthlm temporarily deployed to stage January 13, 2025 09:38 Inactive
@clingen-sthlm clingen-sthlm temporarily deployed to stage January 13, 2025 15:22 Inactive
@clingen-sthlm clingen-sthlm temporarily deployed to stage January 13, 2025 15:53 Inactive
@clingen-sthlm clingen-sthlm temporarily deployed to stage January 14, 2025 08:18 Inactive
@clingen-sthlm clingen-sthlm temporarily deployed to stage January 14, 2025 09:15 Inactive
@clingen-sthlm clingen-sthlm temporarily deployed to stage January 14, 2025 09:30 Inactive
@islean
Copy link
Contributor Author

islean commented Jan 14, 2025

Orders submitted:

image

diitaz93
diitaz93 approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@diitaz93 diitaz93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go 🚀

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@islean islean merged commit e5935fe into improve-order-flow-main Jan 14, 2025
7 checks passed
@islean islean deleted the fix-indices branch January 14, 2025 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diitaz93 diitaz93 diitaz93 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@islean @diitaz93 @clingen-sthlm