Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure multiqc so that it can handle more than 500 rows #4058

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

sofstam
Copy link
Contributor

@sofstam sofstam commented Jan 8, 2025

Description

By default, MultiQC starts using violin plots when a table has 500 rows or more (https://docs.seqera.io/multiqc/getting_started/config) and the file multiqc_general_stats.txt was not generated for thoroughstingray case in production causing an issue in storing the case.

I am planning to move the configs of taxprofiler to servers as the rest of nf-pipelines.

#3853
https://github.com/Clinical-Genomics/servers/pull/1469

Fixed

  • Configure multiqc so that it does not start using violin plots when a certain amount of rows has been reached.

How to prepare for test

  • Ssh to relevant server (depending on type of change)
  • Use stage: us
  • Paxa the environment: paxa
  • Install on stage (example for Hasta):
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_cg -t cg -b multiqc_patch -a

How to test

  • Do ...

Expected test outcome

  • Check that ...
  • Take a screenshot and attach or copy/paste the output.

Tested the case on stage with the new configs and the file was being generated.

Screenshot 2025-01-08 at 09 42 57

Review

  • Tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Document in ...
  • Deploy this branch on ...
  • Inform to ...

@sofstam sofstam requested a review from a team as a code owner January 8, 2025 08:32
Copy link

sonarqubecloud bot commented Jan 8, 2025

@sofstam sofstam requested a review from Karl-Svard January 8, 2025 08:43
Copy link
Contributor

@Karl-Svard Karl-Svard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix!

Copy link
Contributor

@henrikstranneheim henrikstranneheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sofstam sofstam merged commit 53d7b70 into master Jan 8, 2025
10 checks passed
@sofstam sofstam deleted the multiqc_patch branch January 8, 2025 09:05
@sofstam
Copy link
Contributor Author

sofstam commented Jan 8, 2025

Deploy on stage:

Screenshot 2025-01-08 at 10 09 56

@sofstam
Copy link
Contributor Author

sofstam commented Jan 8, 2025

Deploy on production:

Screenshot 2025-01-08 at 10 14 32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants