-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable hidden analysis in TB to be uploaded #4003
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 💯
@@ -75,7 +75,7 @@ def query_trailblazer( | |||
return ReadStream.get_content_from_stream(file_format=FileFormat.JSON, stream=response.text) | |||
|
|||
def get_latest_completed_analysis(self, case_id: str) -> TrailblazerAnalysis | None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this only used for uploads?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so it is used in:
services/slurm_upload_service/slurm_upload_service.py
services/analysis_service/analysis_service.py
apps/tb/api.py
Quality Gate passedIssues Measures |
Description
Can close #502 .
Fixed
How to prepare for test
us
paxa
How to test
cg upload -c case_id
on a hidden analysisExpected test outcome
Review
Thanks for filling in who performed the code review and the test!
This version is a
Implementation Plan