Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable hidden analysis in TB to be uploaded #4003

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

eliottBo
Copy link
Contributor

@eliottBo eliottBo commented Dec 6, 2024

Description

Can close #502 .

Fixed

  • Hidden analyses can be uploaded via the CLI command

How to prepare for test

  • Ssh to relevant server (depending on type of change)
  • Use stage: us
  • Paxa the environment: paxa
  • Install on stage (example for Hasta):
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_cg -t cg -b include-hidden-analysis-trailblazer

How to test

  • Do run cg upload -c case_id on a hidden analysis

Expected test outcome

  • Check that the analysis can be uploaded
  • Take a screenshot and attach or copy/paste the output.

Review

  • Tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Document in ...
  • Deploy this branch on ...
  • Inform to ...

@eliottBo eliottBo requested a review from diitaz93 December 6, 2024 09:47
@eliottBo eliottBo self-assigned this Dec 6, 2024
@eliottBo eliottBo requested a review from a team as a code owner December 6, 2024 09:47
Copy link
Contributor

@diitaz93 diitaz93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 💯

@@ -75,7 +75,7 @@ def query_trailblazer(
return ReadStream.get_content_from_stream(file_format=FileFormat.JSON, stream=response.text)

def get_latest_completed_analysis(self, case_id: str) -> TrailblazerAnalysis | None:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this only used for uploads?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so it is used in:
services/slurm_upload_service/slurm_upload_service.py
services/analysis_service/analysis_service.py
apps/tb/api.py

Copy link

sonarqubecloud bot commented Dec 9, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hidden analyses not found when uploading to scout
3 participants