-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add raredisease scout upload #3591
Conversation
…nical-Genomics/cg into add-raredisease-scout-upload
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rgarding the config building I think we can still improve the readability by not reassigning the variable and also removing the self.load_config field. Also I'm a bit hesitant to add a Store object to all the config builders
I have to say I am really unsure about what exactly you would like to see with removing the |
…path/bam to scout config, use in-place manipulation
…nical-Genomics/cg into add-raredisease-scout-upload
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @rannick! Thanks for cleaning up a lot of this for the other pipelines as well 🥇
Quality Gate failedFailed conditions |
|
Description
Added
Changed
Fixed
How to prepare for test
us
paxa
How to test
Expected test outcome
Review
Thanks for filling in who performed the code review and the test!
This version is a
Implementation Plan