Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate unique sample names #3480

Merged
merged 4 commits into from
Jul 29, 2024
Merged

Conversation

seallard
Copy link
Contributor

Add validation that sample names are unique per case for tomte order.

@seallard seallard requested a review from a team as a code owner July 29, 2024 13:13
@seallard seallard changed the title Validate sample names Validate unique sample names Jul 29, 2024
Copy link
Contributor

@islean islean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Copy link
Contributor

@ChrOertlin ChrOertlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean

cg/services/order_validation_service/models/errors.py Outdated Show resolved Hide resolved
seallard and others added 2 commits July 29, 2024 15:28
@seallard seallard merged commit 3391bdf into improve-order-flow-main Jul 29, 2024
5 checks passed
@seallard seallard deleted the validate-sample-names branch July 29, 2024 13:46
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants