Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typing and add blueprint for converting errors #3476

Merged
merged 3 commits into from
Jul 29, 2024
Merged

Fix typing and add blueprint for converting errors #3476

merged 3 commits into from
Jul 29, 2024

Conversation

islean
Copy link
Contributor

@islean islean commented Jul 29, 2024 •
edited
Loading

Description

Added

Changed

Fixed

  • Some typing and a blueprint method for converting pydantic errors to our own custom errors.

How to prepare for test

  • Ssh to relevant server (depending on type of change)
  • Use stage: us
  • Paxa the environment: paxa
  • Install on stage (example for Hasta): 
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_cg -t cg -b [THIS-BRANCH-NAME] -a

How to test

  • Do ...

Expected test outcome

  • Check that ...
  • Take a screenshot and attach or copy/paste the output.

Review

  • Tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Document in ...
  • Deploy this branch on ...
  • Inform to ...

@islean islean self-assigned this Jul 29, 2024
@islean islean marked this pull request as ready for review July 29, 2024 10:42
@islean islean requested a review from a team as a code owner July 29, 2024 10:42
seallard
seallard approved these changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@seallard seallard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@islean islean merged commit 391c448 into improve-order-flow-main Jul 29, 2024
8 checks passed
@islean islean deleted the patch-typing branch July 29, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seallard seallard seallard approved these changes

Assignees

@islean islean

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@islean @seallard