Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PacBio - implement parsing of failed reads metrics #3469

Merged
merged 3 commits into from
Jul 26, 2024

Conversation

diitaz93
Copy link
Contributor

@diitaz93 diitaz93 commented Jul 26, 2024

Description

Closes https://github.com/Clinical-Genomics/add-new-tech/issues/64
The read metrics we parsed came from a file containing only HiFi data. It is important to parse the failed read metrics too. There is a file containing both HiFi and failed metrics (m84202_240522_135641_s1.ccs_report.json). It is, however, generated by another software so the values are not exactly the same as the metrics parsed before. @J35P312 assured that the difference was negligible.

Added

  • New parameters to parse from ccs file:
    • <Q20 Reads
    • <Q20 Yield (bp)
    • <Q20 Read Length (mean, bp)

Changed

  • Renamed HiFiMetrics model to ReadMetrics
  • The path to the ccs file

Fixed

  • Removed old ccs file usage and fixture

@diitaz93 diitaz93 changed the title first draft PacBio - implement parsing of failed reads metrics Jul 26, 2024
@diitaz93 diitaz93 self-assigned this Jul 26, 2024
Copy link

@diitaz93 diitaz93 marked this pull request as ready for review July 26, 2024 12:19
@diitaz93 diitaz93 requested a review from a team as a code owner July 26, 2024 12:19
Copy link
Contributor

@ChrOertlin ChrOertlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@diitaz93 diitaz93 merged commit 25a53b8 into dev-pacbio-flow Jul 26, 2024
8 checks passed
@diitaz93 diitaz93 deleted the parse-new-ccs-report branch July 26, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants