Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add analysis comment column #3468

Merged
merged 12 commits into from
Jul 29, 2024
Merged

Add analysis comment column #3468

merged 12 commits into from
Jul 29, 2024

Conversation

ivadym
Copy link
Contributor

@ivadym ivadym commented Jul 26, 2024 •
edited
Loading

Description

Part of #2702

Added

  • Force storage comment column to analysis table
  • Force storage comment to delivery report

How to prepare for test

  • Ssh to relevant server (depending on type of change)
  • Use stage: us
  • Paxa the environment: paxa
  • Install on stage (example for Hasta): 
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_cg -t cg -b [THIS-BRANCH-NAME] -a

Expected test outcome

  • Comment column in analysis table
Screenshot 2024-07-29 at 11 31 58
  • Delivery report including comment as a warning
Screenshot 2024-07-29 at 12 19 20

Review

  • Tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Document in ...
  • Deploy this branch on ...
  • Inform to ...

@ivadym ivadym requested a review from a team as a code owner July 26, 2024 11:26
@ivadym ivadym linked an issue Jul 26, 2024 that may be closed by this pull request
Deliveries and storage of incomplete analyses AND proper tracking of deliveries. #2702
Closed
ChrOertlin
ChrOertlin approved these changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@ChrOertlin ChrOertlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ivadym ivadym changed the title Add analysis comment table and add to the delivery report Add analysis comment table and add it to the delivery report Jul 26, 2024
@ivadym ivadym changed the title Add analysis comment table and add it to the delivery report Add analysis comment column and add it to the delivery report Jul 26, 2024
@ivadym ivadym changed the title Add analysis comment column and add it to the delivery report Add analysis comment column Jul 26, 2024
@ivadym ivadym mentioned this pull request Jul 26, 2024
Closed
@ChrOertlin ChrOertlin added the alembic migration Perform a change in database label Jul 29, 2024
@clingen-sthlm clingen-sthlm temporarily deployed to stage July 29, 2024 09:26 Inactive
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ivadym ivadym merged commit 1e3d541 into master Jul 29, 2024
9 checks passed
@ivadym ivadym deleted the add-force-storage-comment branch July 29, 2024 12:59
@ivadym ivadym self-assigned this Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrOertlin ChrOertlin ChrOertlin approved these changes

Assignees

@ivadym ivadym

Labels
alembic migration Perform a change in database
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deliveries and storage of incomplete analyses AND proper tracking of deliveries.
3 participants
@ivadym @ChrOertlin @clingen-sthlm