Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor pacbio metrics parser #3467

Merged
merged 5 commits into from
Jul 26, 2024
Merged

refactor pacbio metrics parser #3467

merged 5 commits into from
Jul 26, 2024

Conversation

diitaz93
Copy link
Contributor

@diitaz93 diitaz93 commented Jul 26, 2024 •
edited
Loading

Description

Refactor PacBio metrics parser to compile with the post-processing flow

Changed

  • Condensed all individual parsers into one
  • Refactored tests

This version is a

  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@diitaz93 diitaz93 marked this pull request as ready for review July 26, 2024 09:28
@diitaz93 diitaz93 requested a review from a team as a code owner July 26, 2024 09:28
seallard
seallard reviewed Jul 26, 2024
View reviewed changes
Copy link
Contributor

@seallard seallard left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about passing a list of paths, it makes the interface for the metrics parser leaky since suddenly the client needs to have logic for finding the different paths and passing them into the parser.

I think it is better to encapsulate the logic for identifying the individual report files in the metrics parser.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@diitaz93 diitaz93 merged commit d2b5835 into dev-pacbio-flow Jul 26, 2024
8 checks passed
@diitaz93 diitaz93 deleted the refactor-pacbio-metrics branch July 26, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seallard seallard seallard left review comments

@ChrOertlin ChrOertlin ChrOertlin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@diitaz93 @ChrOertlin @seallard