Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add(hk service to pacbio flow) #3466

Merged
merged 16 commits into from
Jul 26, 2024
Merged

add(hk service to pacbio flow) #3466

merged 16 commits into from
Jul 26, 2024

Conversation

ChrOertlin
Copy link
Contributor

@ChrOertlin ChrOertlin commented Jul 26, 2024 •
edited
Loading

Description

closes: https://github.com/orgs/Clinical-Genomics/projects/80/views/1?pane=issue&itemId=71880138
closes: https://github.com/Clinical-Genomics/add-new-tech/issues/40

Added

Changed

Fixed

How to prepare for test

  • Ssh to relevant server (depending on type of change)
  • Use stage: us
  • Paxa the environment: paxa
  • Install on stage (example for Hasta): 
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_cg -t cg -b [THIS-BRANCH-NAME] -a

How to test

  • Do ...

Expected test outcome

  • Check that ...
  • Take a screenshot and attach or copy/paste the output.

Review

  • Tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Document in ...
  • Deploy this branch on ...
  • Inform to ...

@ChrOertlin ChrOertlin requested a review from a team as a code owner July 26, 2024 07:53
ChrOertlin
ChrOertlin commented Jul 26, 2024
View reviewed changes
cg/apps/housekeeper/hk.py Outdated Show resolved Hide resolved
diitaz93
diitaz93 reviewed Jul 26, 2024
View reviewed changes
cg/apps/housekeeper/hk.py Outdated Show resolved Hide resolved
diitaz93
diitaz93 reviewed Jul 26, 2024
View reviewed changes
Copy link
Contributor

@diitaz93 diitaz93 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is looking good 👏

diitaz93
diitaz93 approved these changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@diitaz93 diitaz93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

cg/services/post_processing/pacbio/housekeeper_service/pacbio_houskeeper_service.py Show resolved Hide resolved
cg/services/post_processing/pacbio/housekeeper_service/pacbio_houskeeper_service.py Outdated Show resolved Hide resolved
tests/utils/mapping.py Outdated Show resolved Hide resolved
tests/services/post_processing/pacbio/conftest.py Outdated Show resolved Hide resolved
diitaz93
diitaz93 approved these changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@diitaz93 diitaz93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ChrOertlin ChrOertlin merged commit ee9ab63 into dev-pacbio-flow Jul 26, 2024
8 checks passed
@ChrOertlin ChrOertlin deleted the add-pacbio-hk-service branch July 26, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diitaz93 diitaz93 diitaz93 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChrOertlin @diitaz93