Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(dev-branch-pacbio) #3453
feature(dev-branch-pacbio) #3453
Changes from all commits
5018359
b04281b
6c69db4
6137696
6c07296
1d2c34e
e83b91c
32517f0
166a830
8162060
dbeeeae
53a3cd2
d2b5835
25a53b8
2b49c33
ee9ab63
ca4b6b1
cf5a0e4
1a21ecb
b9c23ea
0103b45
597871b
c0c4ce6
7a5df2b
4b380b9
e842068
8b78253
9e7c594
94efad2
705a0be
8380cf2
325b045
e4872ee
eec50e6
7a41cf6
28183de
266822e
77ce384
9692bfa
a0c1775
171eef6
dba4415
6940d27
4a3ff25
6720120
b0501e7
2606b19
079d9c7
53167d9
5ed5666
fbe13d3
b04330e
abccba0
e90789b
65c1995
487ccb8
9d3bd2b
a823c99
463b2d4
17052d4
06482a3
3f36046
d4a6de1
e26ef8e
848eba2
c616758
3fbf44f
bc46e44
445c21c
ebc3ae3
f4eb5d2
3af0845
f0a4d42
f1ed67b
758d862
063bd25
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure we want to use the same function for mapping files to tags as we do to map directories to post-process classes. I feel like that function might be too general. I don't think having a helper function that only applies
PATTERN_TO_DEVICE_MAP
is problematicThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can wrap the map plus the function that returns the device.
This file was deleted.