feat(rm): _add_missing_reads

[henrikstranneheim]

Description

Added

Changed

• Remove _add_missing_reads

Fixed

How to prepare for test

• Ssh to relevant server (depending on type of change)
• Use stage: us
• Paxa the environment: paxa
• Install on stage (example for Hasta):

  bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_cg -t cg -b [THIS-BRANCH-NAME] -a

How to test

• Do ...

Expected test outcome

• Check that ...
• Take a screenshot and attach or copy/paste the output.

Review

• Tests executed by
• "Merge and deploy" approved by
  Thanks for filling in who performed the code review and the test!

This version is a

• MAJOR - when you make incompatible API changes
• MINOR - when you add functionality in a backwards compatible manner
• PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

• Document in ...
• Deploy this branch on ...
• Inform to ...

[seallard]

Nice!

[henrikstranneheim]

@Clinical-Genomics/sysdev Anyone that could help me test this one? We are only removing code , but maybe submitting an order should suffice.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[ChrOertlin]

@henrikstranneheim I will have a look at this. There is likely a refactoring of the submitters coming #3574 . I will try to test and merge before that. Nice if we can remove the function before than.

[ChrOertlin]

Tests

Using balsamic.json in tests/fixtures/cg_weborders/

added to lims:

ticket created

in status

[ChrOertlin]

@Vince-janv Can you double check this for me here?

[Vince-janv]

Nice! @Karl-Svard confirmed that the function is not working and that the value is set later by LIMS

[henrikstranneheim]

Thx for the help! Then I will merge this early next week if you do not beat me to it.

[ChrOertlin]

Thx for the help! Then I will merge this early next week if you do not beat me to it.

@henrikstranneheim I think we can close this pr. I made some headway over the weekend and get the refactoring tested here: #3574

I made sure to remove the _add_missing_reads function there. If you agree you can close this PR, in favour of addressing it in the other.

[henrikstranneheim]

Great!