Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add(yield parsing to bclconvert metrics parser) #3271

Merged
merged 8 commits into from
May 24, 2024
Merged

add(yield parsing to bclconvert metrics parser) #3271

merged 8 commits into from
May 24, 2024

Conversation

ChrOertlin
Copy link
Contributor

Description

Added

Changed

Fixed

How to prepare for test

  • Ssh to relevant server (depending on type of change)
  • Use stage: us
  • Paxa the environment: paxa
  • Install on stage (example for Hasta): 
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_cg -t cg -b [THIS-BRANCH-NAME] -a

How to test

  • Do ...

Expected test outcome

  • Check that ...
  • Take a screenshot and attach or copy/paste the output.

Review

  • Tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Document in ...
  • Deploy this branch on ...
  • Inform to ...

@ChrOertlin ChrOertlin requested a review from a team as a code owner May 23, 2024 12:14
Vince-janv
Vince-janv reviewed May 23, 2024
View reviewed changes
Copy link
Contributor

@Vince-janv Vince-janv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some confusion regarding the calculations 😅

cg/services/bcl_convert_metrics_service/bcl_convert_metrics_service.py Outdated Show resolved Hide resolved
cg/services/bcl_convert_metrics_service/models.py Show resolved Hide resolved
cg/services/bcl_convert_metrics_service/parser.py Outdated Show resolved Hide resolved
cg/services/bcl_convert_metrics_service/parser.py Outdated Show resolved Hide resolved
cg/services/bcl_convert_metrics_service/parser.py Outdated Show resolved Hide resolved
@ChrOertlin ChrOertlin requested review from Vince-janv and diitaz93 May 24, 2024 08:26
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Vince-janv
Vince-janv approved these changes May 24, 2024
View reviewed changes
Copy link
Contributor

@Vince-janv Vince-janv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

diitaz93
diitaz93 approved these changes May 24, 2024
View reviewed changes
Copy link
Contributor

@diitaz93 diitaz93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@ChrOertlin
Copy link
Contributor Author

cg demultiplex finish flow cell command worked. As this changes touched some code related to this command, tests compelte

@ChrOertlin ChrOertlin merged commit 63a8351 into master May 24, 2024
9 checks passed
@ChrOertlin ChrOertlin deleted the rewire-demux-pt4 branch May 24, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vince-janv Vince-janv Vince-janv approved these changes

@diitaz93 diitaz93 diitaz93 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChrOertlin @diitaz93 @Vince-janv