Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update filename for software versions #3240

Merged
merged 31 commits into from
Oct 21, 2024
Merged

Conversation

sofstam
Copy link
Contributor

@sofstam sofstam commented May 17, 2024

Fixed

  • The software_versions.yml has been updated to nf_core_pipeline_software_mqc_versions.yml

How to prepare for test

  • Ssh to relevant server (depending on type of change)
  • Use stage: us
  • Paxa the environment: paxa
  • Install on stage (example for Hasta):
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_cg -t cg -b patch_taxprofiler_versions -a

How to test

  • Do ...

Expected test outcome

  • Check that ...
  • Take a screenshot and attach or copy/paste the output.

Review

  • Tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Document in ...
  • Deploy this branch on ...
  • Inform to ...

@sofstam sofstam marked this pull request as ready for review May 17, 2024 14:17
@sofstam sofstam requested a review from a team as a code owner May 17, 2024 14:17
Copy link
Contributor

@islean islean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Contributor

@ivadym ivadym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

Copy link

@sofstam sofstam merged commit 3dadeff into master Oct 21, 2024
9 checks passed
@sofstam sofstam deleted the patch_taxprofiler_versions branch October 21, 2024 11:27
@sofstam
Copy link
Contributor Author

sofstam commented Oct 21, 2024

Deploy on stage:

Screenshot 2024-10-21 at 13 32 27

@sofstam
Copy link
Contributor Author

sofstam commented Oct 21, 2024

Deploy on production:
Screenshot 2024-10-21 at 13 37 26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants