-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add scout support for tomte #3212
Conversation
tests are passing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great ⭐ Can't say much about the RNA flow unfortunately, as I lack the knowledge, but the implementation looks super clean
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Looks great! 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Quality Gate passedIssues Measures |
To include once this is PR ready: Clinical-Genomics/scout#4654
|
cg/meta/report/templates/macros/uploaded_files/uploaded_files.html
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic work 💯 🌟
Tests were done with genomic-medicine-sweden/tomte: v2.0.1-ge68af17 |
Quality Gate passedIssues Measures |
I am going to close this PR for now as we went for the mip-rna approach of loading rna case to the related dna ones. This should be reopened/something similar should be done when we will homogenize scout loading with config files for all workflows |
Description
Added
Changed
How to prepare for test
us
paxa
How to test
cg workflow tomte store legalpeacock; cg generate delivery-report legalpeacock -f
. Make sure delivery type is set toscout
.cg upload -c legalpeacock -r
. Make sure the upload is successfulomics_files: {}
and Scout should not show the outliers table.Review
Thanks for filling in who performed the code review and the test!
This version is a
Implementation Plan