Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scout support for tomte #3212

Closed
wants to merge 45 commits into from
Closed

Add scout support for tomte #3212

wants to merge 45 commits into from

Conversation

fevac
Copy link
Contributor

@fevac fevac commented May 8, 2024

Description

Added

  • Scout config creation and upload for tomte

Changed

  • Updated delivery report for tomte to include information about which files are uploaded to Scout

How to prepare for test

  • Ssh to relevant server (depending on type of change)
  • Use stage: us
  • Paxa the environment: paxa
  • Install on stage (example for Hasta):
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_cg -t cg -b add_scout_for_tomte -a

How to test

  • Store case and generate report if not done already,cg workflow tomte store legalpeacock; cg generate delivery-report legalpeacock -f . Make sure delivery type is set to scout.
  • cg upload -c legalpeacock -r . Make sure the upload is successful
  • The scout_load.yaml should look like this:
---
analysis_date: 2024-08-07 10:05:18
default_gene_panels: []
delivery_report: /home/proj/stage/housekeeper-bundles/legalpeacock/2024-08-07/delivery-report.html
family: legalpeacock
family_name: XXXX-RNA-5M_downsampled
gene_panels:
- BRAIN
- Cardiology
- CILM
- CH
- CTD
- DIAB
- ENDO
- EP
- HEARING
- HYDRO
- IBMFS
- IEM
- IF
- mcarta
- MHT
- MIT
- MOVE
- mtDNA
- NBS-M
- NEURODEG
- NMD
- OMIM-AUTO
- OPTIC
- PANELAPP-GREEN
- PEDHEP
- PID
- PIDCAD
- RETINA
- SKD
- SOVM
- STROKE
- AID
- Inherited cancer
human_genome_build: '38'
multiqc_rna: /home/proj/stage/housekeeper-bundles/legalpeacock/2024-08-07/multiqc_report.html
omics_files:
  fraser: /home/proj/stage/housekeeper-bundles/legalpeacock/2024-08-07/legalpeacock_fraser_top_hits_clinical.tsv
  outrider: /home/proj/stage/housekeeper-bundles/legalpeacock/2024-08-07/legalpeacock_outrider_top_hits_clinical.tsv
owner: cust000
samples:
- analysis_type: wts
  father: '0'
  mother: '0'
  phenotype: unknown
  rna_alignment_path: /home/proj/stage/housekeeper-bundles/legalpeacock/2024-08-07/ACC9480A3DS5C0M.cram
  rna_coverage_bigwig: /home/proj/stage/housekeeper-bundles/legalpeacock/2024-08-07/ACC9480A3DS5C0M.bw
  sample_id: ACC9480A3DS5C0M
  sample_name: ACC9480A3DS5C0M
  sex: male
  splice_junctions_bed: /home/proj/stage/housekeeper-bundles/legalpeacock/2024-08-07/ACC9480A3DS5C0M_junction.bed.gz
  tissue_type: unknown
track: rare
vcf_snv: /home/proj/stage/housekeeper-bundles/legalpeacock/2024-08-07/legalpeacock_vep_clinical.vcf.gz
vcf_snv_research: /home/proj/stage/housekeeper-bundles/legalpeacock/2024-08-07/legalpeacock_vep_research.vcf.gz
  • Scout contains Clinical WTS outliers
image
  • Test scout upload for a case for which DROP was not run. scout_load.yaml should contain omics_files: {} and Scout should not show the outliers table.
image
  • Delivery report is updated to include information about files uploaded to Scout

Review

  • Tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Document in ...
  • Deploy this branch on ...
  • Inform to ...

@fevac
Copy link
Contributor Author

fevac commented May 28, 2024

tests are passing

@fevac fevac marked this pull request as ready for review May 28, 2024 09:31
@fevac fevac requested a review from a team as a code owner May 28, 2024 09:31
Copy link
Contributor

@diitaz93 diitaz93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great ⭐ Can't say much about the RNA flow unfortunately, as I lack the knowledge, but the implementation looks super clean

tests/meta/upload/scout/test_generate_load_config.py Outdated Show resolved Hide resolved
tests/meta/upload/scout/test_generate_load_config.py Outdated Show resolved Hide resolved
cg/meta/upload/scout/tomte_config_builder.py Outdated Show resolved Hide resolved
cg/meta/upload/scout/tomte_config_builder.py Outdated Show resolved Hide resolved
Copy link
Contributor

@ivadym ivadym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Looks great! 💯

cg/constants/scout.py Outdated Show resolved Hide resolved
cg/meta/upload/scout/hk_tags.py Outdated Show resolved Hide resolved
cg/meta/upload/scout/tomte_config_builder.py Outdated Show resolved Hide resolved
cg/meta/upload/scout/tomte_config_builder.py Outdated Show resolved Hide resolved
cg/meta/upload/scout/tomte_config_builder.py Outdated Show resolved Hide resolved
tests/meta/upload/scout/conftest.py Outdated Show resolved Hide resolved
tests/meta/upload/scout/conftest.py Outdated Show resolved Hide resolved
tests/meta/upload/scout/conftest.py Outdated Show resolved Hide resolved
tests/meta/upload/scout/conftest.py Outdated Show resolved Hide resolved
tests/meta/upload/scout/test_scout_config_builder.py Outdated Show resolved Hide resolved
Copy link
Contributor

@henrikstranneheim henrikstranneheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

cg/meta/upload/scout/tomte_config_builder.py Outdated Show resolved Hide resolved
cg/meta/upload/scout/tomte_config_builder.py Outdated Show resolved Hide resolved
cg/meta/upload/scout/uploadscoutapi.py Show resolved Hide resolved
tests/meta/upload/scout/conftest.py Outdated Show resolved Hide resolved
tests/meta/upload/scout/conftest.py Outdated Show resolved Hide resolved
tests/meta/upload/scout/conftest.py Outdated Show resolved Hide resolved
tests/meta/upload/scout/test_generate_load_config.py Outdated Show resolved Hide resolved
tests/meta/upload/scout/test_generate_load_config.py Outdated Show resolved Hide resolved
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@fevac
Copy link
Contributor Author

fevac commented Aug 6, 2024

To include once this is PR ready: Clinical-Genomics/scout#4654

  • fraser_tsv
  • outrider_tsv

cg/constants/scout.py Outdated Show resolved Hide resolved
Copy link
Contributor

@ivadym ivadym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic work 💯 🌟

@fevac
Copy link
Contributor Author

fevac commented Aug 8, 2024

@jemten @rannick this PR is ready and reviewed. Whenever ready to be put in production just merge master and you should be good to go

@fevac
Copy link
Contributor Author

fevac commented Aug 12, 2024

Tests were done with genomic-medicine-sweden/tomte: v2.0.1-ge68af17

Copy link

@rannick
Copy link
Contributor

rannick commented Sep 27, 2024

I am going to close this PR for now as we went for the mip-rna approach of loading rna case to the related dna ones. This should be reopened/something similar should be done when we will homogenize scout loading with config files for all workflows

@rannick rannick closed this Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants