Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove feature to link order to an existing ticket #4013

Merged
merged 5 commits into from
Dec 16, 2024
Merged

Remove feature to link order to an existing ticket #4013

merged 5 commits into from
Dec 16, 2024

Conversation

ahdamin
Copy link
Contributor

@ahdamin ahdamin commented Dec 10, 2024 •
edited by diitaz93
Loading

Description

It was agreed by sysdev and prod to remove the option to link an existing ticket to an order in the order portal. This PR implements the backend changes.

Changed

  • Remove the feature to link orders to an existing ticket

How to prepare for test

  • Ssh to relevant server (depending on type of change)
  • Use stage: us
  • Paxa the environment: paxa
  • Install on stage (example for Hasta): 
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_cg -t cg -b [THIS-BRANCH-NAME] -a

How to test

  • Do ...

Expected test outcome

  • Check that ...
  • Take a screenshot and attach or copy/paste the output.

Review

  • Tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Document in ...
  • Deploy this branch on ...
  • Inform to ...

@ahdamin ahdamin linked an issue Dec 10, 2024 that may be closed by this pull request
Remove feature to link order to existing ticket #3942
Closed
2 tasks
@ahdamin ahdamin changed the title Remove feature to link order to existing ticket Remove feature to link order to an existing ticket Dec 10, 2024
@ahdamin ahdamin marked this pull request as ready for review December 10, 2024 10:23
@ahdamin ahdamin requested a review from a team as a code owner December 10, 2024 10:23
@ahdamin ahdamin self-assigned this Dec 10, 2024
ChrOertlin
ChrOertlin approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@ChrOertlin ChrOertlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

diitaz93
diitaz93 approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@diitaz93 diitaz93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 💯

islean
islean approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@islean islean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@ahdamin
Copy link
Contributor Author

ahdamin commented Dec 13, 2024

Tested with FE PR.
Checkbox was removed
Screenshot 2024-12-13 at 10 40 15

Order with the following details was successfully submitted:

2024-12-13 10:43:09 172.18.0.1 - - [13/Dec/2024:09:43:09 +0000] "OPTIONS /api/v1/submit_order/balsamic HTTP/1.1" 204 0 "https://localhost:3001/" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/131.0.0.0 Safari/537.36"
2024-12-13 10:43:09 [2024-12-13 09:43:09 +0000] [12] [DEBUG] POST /api/v1/submit_order/balsamic
2024-12-13 10:43:09 2024-12-13 09:43:09 20b0307265fd cg.server.endpoints.orders[12] INFO processing order: {"customer": "cust000", "name": "ORDER_TEST_ISSUE_ 4013", "samples": [{"name": "SampleTestingIssue4013", "sex": "male", "subject_id": "Subject4013", "application": "EXOKTTR040", "elution_buffer": "Nuclease-free water", "source": "blood", "container": "Tube", "volume": 120, "data_analysis": "balsamic", "data_delivery": "no-delivery", "family_name": "TestingIssue4013", "cohorts": [], "phenotype_groups": [], "phenotype_terms": [], "priority": "research"}]}
2024-12-13 10:43:10 2024-12-13 09:43:10 20b0307265fd cg.meta.orders.ticket_handler[12] INFO 1001608: opened new ticket in Freshdesk
2024-12-13 10:43:10 2024-12-13 09:43:10 20b0307265fd cg.apps.lims.order[12] INFO STG15713: created new LIMS project
2024-12-13 10:43:11 2024-12-13 09:43:11 20b0307265fd cg.services.orders.submitters.order_submitter[12] INFO SampleTestingIssue4013 -> STG15713A1: connect sample to LIMS

Screenshot 2024-12-13 at 10 43 18

@ahdamin ahdamin mentioned this pull request Dec 13, 2024
Closed
2 tasks
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@diitaz93 diitaz93 merged commit abb504d into master Dec 16, 2024
10 checks passed
@diitaz93 diitaz93 deleted the stop-order-extisting-ticket branch December 16, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@islean islean islean approved these changes

@diitaz93 diitaz93 diitaz93 approved these changes

@ChrOertlin ChrOertlin ChrOertlin approved these changes

Assignees

@ahdamin ahdamin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove feature to link order to existing ticket
4 participants
@ahdamin @ChrOertlin @diitaz93 @islean