Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove feature to link order to existing ticket #3942

Closed
2 tasks done
Vince-janv opened this issue Nov 15, 2024 · 2 comments · Fixed by #4013
Closed
2 tasks done

Remove feature to link order to existing ticket #3942

Vince-janv opened this issue Nov 15, 2024 · 2 comments · Fixed by #4013
Assignees

Comments

@Vince-janv
Copy link
Contributor

Vince-janv commented Nov 15, 2024

As a developer,
I want to remove the existing ticket logic when ordering,
So that we don't have to maintain that logic in the already complex order logc

Work impact

Answer the following questions:

  • Is there currently a workaround for this issue? If so, what is it?
    • N/A
  • How much time would be saved by implementing this feature on a weekly basis?
    • Aggregate gains everytime we need to touch the ordering logic
  • How many users are affected by this issue?
    • back-end devs
  • Are customers affected by this issue?
    • No

Acceptance Criteria

  • The FE option to connect to a ticket is removed
  • All logic pertaining to the existing ticket linking is removed
    ...

Notes

  • This feature was used regularly by one customer and very sporadically for some research projects
  • @AnnaZetterlund has communicated with the customer to use our normal ordering flow 🙏
@diitaz93
Copy link
Contributor

diitaz93 commented Dec 5, 2024

Technical refinement

FE

  • Remove the checkbox in the order portal

BE

  • Remove the logic regarding connect to ticket in the OrdersAPI
  • Remove the extra validation in the orders endpoint

@ahdamin ahdamin self-assigned this Dec 10, 2024
@ahdamin ahdamin linked a pull request Dec 10, 2024 that will close this issue
15 tasks
@ahdamin
Copy link
Contributor

ahdamin commented Dec 13, 2024

BE and FE PRs are ready. @diitaz93 Feel free to merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants