Rename error

Clinical-Genomics · Jul 29, 2024 · fa171d8 · fa171d8
1 parent add63a6
commit fa171d8
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 9 deletions.
diff --git a/cg/services/order_validation_service/models/errors.py b/cg/services/order_validation_service/models/errors.py
@@ -55,6 +55,6 @@ class OccupiedWellError(CaseSampleError):
     message: str = "Well is already occupied"
 
 
-class ReusedSampleNameError(CaseSampleError):
+class RepeatedSampleNameError(CaseSampleError):
     field: str = "name"
     message: str = "Sample name already used"
diff --git a/cg/services/order_validation_service/workflows/tomte/validation/inter_field/rules.py b/cg/services/order_validation_service/workflows/tomte/validation/inter_field/rules.py
@@ -1,6 +1,6 @@
 from cg.services.order_validation_service.models.errors import (
     OccupiedWellError,
-    ReusedSampleNameError,
+    RepeatedSampleNameError,
 )
 from cg.services.order_validation_service.workflows.tomte.models.order import TomteOrder
 from cg.services.order_validation_service.workflows.tomte.validation.inter_field.utils import (
@@ -17,8 +17,8 @@ def validate_wells_contain_at_most_one_sample(order: TomteOrder) -> list[Occupie
     return _get_errors(samples)
 
 
-def validate_unique_sample_names_in_cases(order: TomteOrder) -> list[ReusedSampleNameError]:
-    errors: list[ReusedSampleNameError] = []
+def validate_unique_sample_names_in_cases(order: TomteOrder) -> list[RepeatedSampleNameError]:
+    errors: list[RepeatedSampleNameError] = []
     for case in order.cases:
         case_errors = get_duplicate_sample_name_errors(case)
         errors.extend(case_errors)

diff --git a/cg/services/order_validation_service/workflows/tomte/validation/inter_field/utils.py b/cg/services/order_validation_service/workflows/tomte/validation/inter_field/utils.py
@@ -2,7 +2,7 @@
 from cg.models.orders.sample_base import ContainerEnum
 from cg.services.order_validation_service.models.errors import (
     OccupiedWellError,
-    ReusedSampleNameError,
+    RepeatedSampleNameError,
 )
 from cg.services.order_validation_service.workflows.tomte.models.case import TomteCase
 from cg.services.order_validation_service.workflows.tomte.models.order import TomteOrder
@@ -59,6 +59,6 @@ def get_duplicate_sample_names(case: TomteCase) -> list[str]:
     return [name for name, freq in count.items() if freq > 1]
 
 
-def get_duplicate_sample_name_errors(case: TomteCase) -> list[ReusedSampleNameError]:
+def get_duplicate_sample_name_errors(case: TomteCase) -> list[RepeatedSampleNameError]:
     sample_names = get_duplicate_sample_names(case)
-    return [ReusedSampleNameError(sample_name=name, case_name=case.name) for name in sample_names]
+    return [RepeatedSampleNameError(sample_name=name, case_name=case.name) for name in sample_names]
diff --git a/tests/services/order_validation_service/test_tomte_inter_field_validators.py b/tests/services/order_validation_service/test_tomte_inter_field_validators.py
@@ -1,6 +1,6 @@
 from cg.services.order_validation_service.models.errors import (
     OccupiedWellError,
-    ReusedSampleNameError,
+    RepeatedSampleNameError,
 )
 from cg.services.order_validation_service.workflows.tomte.models.order import TomteOrder
 from cg.services.order_validation_service.workflows.tomte.validation.inter_field.rules import (
@@ -44,4 +44,4 @@ def test_duplicate_sample_names_not_allowed(order_with_duplicate_sample_names: T
     assert errors
 
     # THEN the errors are about the sample names
-    assert isinstance(errors[0], ReusedSampleNameError)
+    assert isinstance(errors[0], RepeatedSampleNameError)