Remove old pacbio validation (#4088)

Remove old pacbio validation
Clinical-Genomics · Jan 15, 2025 · b06e8c9 · b06e8c9
1 parent f09e33e
commit b06e8c9
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 155 deletions.
diff --git a/cg/services/order_validation_service/rules/sample/rules.py b/cg/services/order_validation_service/rules/sample/rules.py
@@ -1,5 +1,4 @@
 from cg.models.orders.constants import OrderType
-from cg.models.orders.sample_base import ControlEnum
 from cg.services.order_validation_service.errors.sample_errors import (
     ApplicationArchivedError,
     ApplicationNotCompatibleError,
@@ -18,6 +17,7 @@
     OrganismDoesNotExistError,
     PoolApplicationError,
     PoolPriorityError,
+    SampleNameNotAvailableControlError,
     SampleNameNotAvailableError,
     SampleNameRepeatedError,
     VolumeRequiredError,
@@ -275,12 +275,12 @@ def validate_sample_names_available(
 
 def validate_non_control_sample_names_available(
     order: OrderWithControlSamples, store: Store, **kwargs
-) -> list[SampleNameNotAvailableError]:
+) -> list[SampleNameNotAvailableControlError]:
     """
     Validate that non-control sample names do not exists in the database under the same customer.
     Applicable to all orders with control samples.
     """
-    errors: list[SampleNameNotAvailableError] = get_sample_name_not_available_errors(
+    errors: list[SampleNameNotAvailableControlError] = get_sample_name_not_available_errors(
         order=order, store=store, has_order_control=True
     )
     return errors

diff --git a/cg/services/orders/validate_order_services/validate_pacbio_order.py b/cg/services/orders/validate_order_services/validate_pacbio_order.py
diff --git a/tests/fixture_plugins/orders_fixtures/order_to_submit_fixtures.py b/tests/fixture_plugins/orders_fixtures/order_to_submit_fixtures.py
@@ -12,6 +12,7 @@
 from cg.services.order_validation_service.workflows.fastq.models.order import FastqOrder
 from cg.services.order_validation_service.workflows.mip_dna.models.order import MipDnaOrder
 from cg.services.order_validation_service.workflows.mip_rna.models.order import MipRnaOrder
+from cg.services.order_validation_service.workflows.pacbio_long_read.models.order import PacbioOrder
 
 
 @pytest.fixture(scope="session")
@@ -145,9 +146,7 @@ def all_orders_to_submit(
         # ),
         OrderType.MIP_DNA: MipDnaOrder.model_validate(mip_dna_order_to_submit),
         OrderType.MIP_RNA: MipRnaOrder.model_validate(mip_rna_order_to_submit),
-        OrderType.PACBIO_LONG_READ: OrderIn.parse_obj(
-            pacbio_order_to_submit, project=OrderType.PACBIO_LONG_READ
-        ),
+        OrderType.PACBIO_LONG_READ: PacbioOrder.model_validate(pacbio_order_to_submit),
         # OrderType.RML: OrderIn.parse_obj(rml_order_to_submit, project=OrderType.RML),
         # OrderType.RNAFUSION: RnaFusionOrder.model_validate(rnafusion_order_to_submit),
         # OrderType.SARS_COV_2: OrderIn.parse_obj(

diff --git a/tests/services/orders/test_validate_order_service/conftest.py b/tests/services/orders/test_validate_order_service/conftest.py
diff --git a/tests/services/orders/test_validate_order_service/test_validate_pacbio_order_service.py b/tests/services/orders/test_validate_order_service/test_validate_pacbio_order_service.py