Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle insufficent resources for samtools mpileup #50

Open
sylvinite opened this issue Apr 6, 2021 · 2 comments
Open

Handle insufficent resources for samtools mpileup #50

sylvinite opened this issue Apr 6, 2021 · 2 comments
Labels
Bug Something isn't working Effort S Effort small Gain S Gain small
Milestone

Comments

@sylvinite
Copy link
Collaborator

What needs to be done:
Samtools mpileup may softcrash and provide incorrect consensus data
GMS-artic/MUTANT needs to detect this, interupt the run and throw an error.

Suggestions on how to get it done:
Preferably directly in https://github.com/genomic-medicine-sweden/gms-artic
Otherwise add a function in MUTANT
Check the mpileup log for crash information?
Otherwise evaluate the consensus file for poly-nucleotide tails

What are the arguments for getting it done:
The error breaks results and is currently undetectable.
If we don't solve this, we may never trim down the amount of resources allocated to MUTANT.

Task is considered finished when:
Run MUTANT with minimal resources on the testdata. This should cause the error, trigger the interupt and throw the error

@sylvinite sylvinite added Effort S Effort small Enhancement New feature or request Gain S Gain small labels Apr 6, 2021
@sylvinite
Copy link
Collaborator Author

Linked issue in genomic-medicine-sweden/gms-artic#3

@sylvinite sylvinite added Bug Something isn't working and removed Enhancement New feature or request labels Apr 23, 2021
@pbiology pbiology added this to the TBD milestone Jun 26, 2023
@pbiology
Copy link
Contributor

Right now handeld by throwing more memory on the task. Has not been a concern for quite some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Effort S Effort small Gain S Gain small
Projects
None yet
Development

No branches or pull requests

3 participants