Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable the automatic use of latest gms-artic containers #162

Open
pbiology opened this issue Dec 16, 2022 · 2 comments
Open

Disable the automatic use of latest gms-artic containers #162

pbiology opened this issue Dec 16, 2022 · 2 comments
Labels
Effort M Effort medium Gain S Gain small Urgency S Urgency small
Milestone

Comments

@pbiology
Copy link
Contributor

What needs to be done:
When new docker containers from gms-artic is built, we automatically download them and use them in production. This can cause issues if the new containers contain updates we haven't tested in production.

Suggestions on how to get it done:

  • Make sure we understand how we are using the gms-artic containers
  • Check for a solution where we don't always use the latest version

What are the arguments for getting it done:

  • Will cause less problems for production if gms-artic is updated without us knowing it

Task is considered finished when:

  • We have control over what containers are used in production
@pbiology pbiology added Effort M Effort medium Gain M Gain medium Urgency M Urgency medium labels Dec 16, 2022
@pbiology pbiology added this to the Release 5 milestone Jun 29, 2023
@talnor
Copy link
Contributor

talnor commented Sep 14, 2023

Updates are due to that the pangolin-data is installed in the docker images (and needs to be updated frequently). If the data is located elsewhere, we can use fixed image versions. Related issue in gms-artic here: genomic-medicine-sweden/gms-artic#81

@talnor
Copy link
Contributor

talnor commented Jan 24, 2024

As of PR #164 we use a separate docker image for pangolin. Meaning that we have a more robust set up and have control over the other tools that are used. However, the issue remains for updates of pangolin in gms-artic.

Updating urgency and gain accordingly.

@talnor talnor added Gain S Gain small Urgency S Urgency small and removed Gain M Gain medium Urgency M Urgency medium labels Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Effort M Effort medium Gain S Gain small Urgency S Urgency small
Projects
None yet
Development

No branches or pull requests

2 participants