Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply libunwind fix #66977

Merged
merged 3 commits into from
Jul 25, 2024
Merged

Apply libunwind fix #66977

merged 3 commits into from
Jul 25, 2024

Conversation

al13n321
Copy link
Member

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

ClickHouse/libunwind#30

@robot-ch-test-poll4 robot-ch-test-poll4 added pr-not-for-changelog This PR should not be mentioned in the changelog submodule changed At least one submodule changed in this PR. labels Jul 23, 2024
@robot-ch-test-poll3
Copy link
Contributor

robot-ch-test-poll3 commented Jul 23, 2024 •
edited by robot-ch-test-poll2
Loading

This is an automated comment for commit 36e59a1 with description of existing statuses. It's updated for the latest CI running

✅ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success

@antonio2368 antonio2368 self-assigned this Jul 24, 2024
antonio2368
antonio2368 approved these changes Jul 24, 2024
View reviewed changes
Copy link
Member

@antonio2368 antonio2368 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the reference to commit in master of libunwind contrib once you are happy
This change doesn't break anything I checked. 👍

@antonio2368 antonio2368 self-requested a review July 24, 2024 14:27
@al13n321 al13n321 marked this pull request as ready for review July 25, 2024 01:58
@al13n321 al13n321 enabled auto-merge July 25, 2024 01:59
@al13n321 al13n321 added this pull request to the merge queue Jul 25, 2024
Merged via the queue into master with commit 1b2fd51 Jul 25, 2024
18 of 28 checks passed
@al13n321 al13n321 deleted the uwo branch July 25, 2024 04:01
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jul 25, 2024
@antonio2368 antonio2368 mentioned this pull request Jul 25, 2024
Merged
19 tasks
@antonio2368 antonio2368 added the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label Sep 20, 2024
This was referenced Sep 20, 2024
Closed
Closed
Merged
robot-clickhouse added a commit that referenced this pull request Sep 20, 2024
@robot-clickhouse
Backport #66977 to 24.7: Apply libunwind fix
86fed01
@robot-ch-test-poll3 robot-ch-test-poll3 mentioned this pull request Sep 20, 2024
Merged
@robot-clickhouse robot-clickhouse added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Sep 20, 2024
robot-ch-test-poll4 added a commit that referenced this pull request Sep 20, 2024
@robot-ch-test-poll4
Merge pull request #69802 from ClickHouse/backport/24.7/66977
f39cfb0 
Backport #66977 to 24.7: Apply libunwind fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonio2368 antonio2368 antonio2368 approved these changes

Assignees

@antonio2368 antonio2368

Labels
pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo submodule changed At least one submodule changed in this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@al13n321 @robot-ch-test-poll3 @antonio2368 @robot-clickhouse @robot-ch-test-poll4 @robot-clickhouse-ci-2