Update dependencies and add ocean mask #808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmdeck
commented
Oct 2, 2024
| @@ -400,9 +400,9 @@ if device_suffix == "cpu" | |||
| titles = ["W", "σS", "T_sfc"] | |||
| for (f, n) in zip(fields, titles) | |||
| fig = Figure(size = (1000, 1000)) | |||
| ax = Axis(fig[1, 1]) | |||
| ax = Axis(fig[1, 1], title = n) | |||
There was a problem hiding this comment.
I had to make this change to get this to pass, Gabriele.
kmdeck
force-pushed
the
kd/up_buildkite_add_mask
branch
from
9a567f4
to
04eb4f0
Compare
|
@juliasloan25 the long_run/bucket.jl script runs here, so maybe we can merge this first, and then your PR? |
kmdeck
force-pushed
the
kd/up_buildkite_add_mask
branch
from
7544df8
to
0670b7d
Compare
juliasloan25
approved these changes
Oct 3, 2024
There was a problem hiding this comment.
This looks good to me! The longrun plots still look good. We might want to make a note (in the commit or PR description) that the ocean mask is just used for plotting.
We'll also need to update to ClimaCore v0.14.18 after it's released later today, but I'm happy to do that as part of #675
AlexisRenchon
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
To-do
Future PR: move long_run/bucket.jl to experiments/standalone/Bucket/ in place of bucket_era5.jl
At the same time, use ClimaDiagnostics for all standalone bucket runs and compare diagnostics, not output state to CSV.
Replace plotting with ClimaAnalysis
Content