Add HF datalayouts #2055
Open
Add HF datalayouts #2055
+1,828
−202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleskawczynski
force-pushed
the
ck/HF_datalayouts
branch
8 times, most recently
from
c1ad750
to
abab1a8
Compare
charleskawczynski
force-pushed
the
ck/HF_datalayouts
branch
from
abab1a8
to
9ba4a0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for new datalayouts:
VIJHFIJHFIHFVIHFFor these new datalayouts, and other datalayouts that end with the field index, we'll be able to add fast paths for linear indexing. This will simply involve reviving #1922, and specializing on all datalayouts with the field index at the end.
Finally, we can compare this with our
VIJFHdatalayout performance.To make this work with our existing implementation, users can now make horizontal spaces with a new keyword argument:
HorizontalLayout = DataLayouts.IJFH, which users may change toHorizontalLayout = DataLayouts.IJHFto try the new datalayout.