Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 2019 #2025

Merged
merged 4 commits into from
Oct 3, 2024
Merged

Fix 2019 #2025

merged 4 commits into from
Oct 3, 2024

Conversation

charleskawczynski
Copy link
Member

Closes #2019, supersedes #2016.

Copy link
Member

@juliasloan25 juliasloan25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@charleskawczynski
Copy link
Member Author

thank you!

Likewise!

@charleskawczynski
Copy link
Member Author

charleskawczynski commented Oct 3, 2024

Ah, case2 is not satisfied for the land example, so we do need support for the multiple field solve in parallel, I think I see how we can do this. If this doesn't work, I'll add a temporary 3rd case, case3 = any(name -> cheap_inv(A[name, name]), names.values), which will certainly work.

@charleskawczynski
Copy link
Member Author

@dennisYatunin, not for now, but is it safe to split up the solves into pointwise (e.g., UniformScaling) and others?

@charleskawczynski
Copy link
Member Author

Alright, I had to resort to the 3rd case, case3 = any(name -> cheap_inv(A[name, name]), names.values), because I'm seeing InvalidIR errors in unzip_tuple_field_values. We might be able to hoist those getindex calls, but I'll leave that for another time.

We do still have the PTX error, I'll add that as a soft-fail and merge.

@charleskawczynski charleskawczynski merged commit 4a2d03e into main Oct 3, 2024
10 of 11 checks passed
@charleskawczynski charleskawczynski deleted the ck/fix_land_repro branch October 3, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

#1992 broke the gpu multiple field solve for the land
3 participants