Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a MWE for tuning compute_kinetic! function. #1385

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

Add a MWE for tuning compute_kinetic! function. #1385

wants to merge 12 commits into from

Conversation

sriharshakandala
Copy link
Member

@sriharshakandala sriharshakandala commented Jul 17, 2023 •
edited by bloops
Loading

Add a MWE for tuning compute_kinetic! function.

  • Code follows the style guidelines OR N/A.
  • Unit tests are included OR N/A.
  • Code is exercised in an integration test OR N/A.
  • Documentation has been added/updated OR N/A.

@sriharshakandala sriharshakandala linked an issue Jul 17, 2023 that may be closed by this pull request
Specialized stencil for kinetic energy #1378
Closed
@sriharshakandala sriharshakandala force-pushed the sk/ke_kernel_opt branch 2 times, most recently from da868a1 to 4def3a5 Compare July 17, 2023 21:39
@sriharshakandala
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Jul 18, 2023
@bors
Try #1385:
dc3dad4
@bors
Copy link
Contributor

bors bot commented Jul 18, 2023

try

Build failed:

@sriharshakandala sriharshakandala force-pushed the sk/ke_kernel_opt branch 2 times, most recently from 849f18b to 37a22f1 Compare July 19, 2023 00:35
@sriharshakandala
Add a MWE for tuning compute_kinetic! function.
be26e08 
Try a different launch configuration for copyto_stencil_kernel
@sriharshakandala
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Jul 19, 2023
@bors
Try #1385:
cc13924
@bors
Copy link
Contributor

bors bot commented Jul 19, 2023

try

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@simonbyrne
Copy link
Member

Yes, probably a good idea to create a function which takes a given device and creates the appropriate space and fields.

@bloops bloops self-requested a review July 19, 2023 20:22
@sriharshakandala sriharshakandala linked an issue Jul 20, 2023 that may be closed by this pull request
Profiling and tuning ClimaCore GPU kernels #1388
Open
@simonbyrne simonbyrne mentioned this pull request Jul 21, 2023
Closed
@sriharshakandala sriharshakandala mentioned this pull request Jul 26, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bloops bloops bloops left review comments

@simonbyrne simonbyrne simonbyrne left review comments

@charleskawczynski charleskawczynski charleskawczynski left review comments

Assignees
No one assigned
Labels
Work-in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Profiling and tuning ClimaCore GPU kernels Specialized stencil for kinetic energy
4 participants
@sriharshakandala @simonbyrne @bloops @charleskawczynski