Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Modder Attach Structure to Dimension #83

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Ecdcaeb
Copy link
Contributor

@Ecdcaeb Ecdcaeb commented Mar 2, 2024

In the old forge. The Structure could not be attached without dark-magic.(Transformation)
On the one hand, structure is a two-step-generated WorldGen, we could not generate it simply use existed events.
On the other hand, the vanilla and mods generate the Structure hardcodely.

In order to solve it, Hileb opened this pr.

What this pr could bring :

  • make the structure attachable. (eg. spawn it in vanilla dimensions )
  • make the /locate command func_184883_a (tab completion) return correct words. (It was hardcoded past.)

@kappa-maintainer
Copy link
Collaborator

Please don't use 1 as commit message anymore
Use this if you are too lazy: https://cz-git.qbb.sh/zh/

@Ecdcaeb
Copy link
Contributor Author

Ecdcaeb commented Mar 2, 2024

Please don't use 1 as commit message anymore Use this if you are too lazy: https://cz-git.qbb.sh/zh/

Just see it as init or set up.
*~*

Since the pr will be intergrated into one commit...
Sorry...

@Rongmario
Copy link
Member

Interesting PR that can be pulled in later this week, I'll play around with it.

@Ecdcaeb Ecdcaeb marked this pull request as draft May 21, 2024 15:23
@Ecdcaeb Ecdcaeb marked this pull request as ready for review May 21, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants