Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SoundManager handling when no sound devices exist #226

Merged
merged 9 commits into from
Oct 18, 2024
Merged

Fix SoundManager handling when no sound devices exist #226

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
5276af6
port https://github.com/GTNewHorizons/lwjgl3ify/pull/173/files
Ecdcaeb Oct 17, 2024
c8ad164
Revert "port https://github.com/GTNewHorizons/lwjgl3ify/pull/173/files"
Ecdcaeb Oct 18, 2024
a528b4c
destroy the divice
Ecdcaeb Oct 18, 2024
521f5bc
Merge branch 'fix_sound' into gtnh-fly-173
Ecdcaeb Oct 18, 2024
57667ec
Update AL.java
Ecdcaeb Oct 18, 2024
91468b4
destroy only when created
Ecdcaeb Oct 18, 2024
62639f9
is it needed to alcDestroyContext for 0L?
Ecdcaeb Oct 18, 2024
7878335
Merge branch 'fix_sound' into gtnh-fly-173
Ecdcaeb Oct 18, 2024
616da1b
check null before close them
Ecdcaeb Oct 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/main/java/org/lwjgl/openal/AL.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,10 +70,14 @@ public static boolean isCreated() {
}

public static void destroy() {
org.lwjgl3.openal.ALC10.alcDestroyContext(alcContext.context);
org.lwjgl3.openal.ALC10.alcCloseDevice(alcDevice.device);
alcContext = null;
alcDevice = null;
if (alcContext != null) {
org.lwjgl3.openal.ALC10.alcDestroyContext(alcContext.context);
alcContext = null;
}
if (alcDevice != null) {
org.lwjgl3.openal.ALC10.alcCloseDevice(alcDevice.device);
alcDevice = null;
}
created = false;
}

Expand Down