Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set environment name for the releases #291

Merged
merged 2 commits into from
Feb 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/release-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
name: Upload release to PyPI Test
runs-on: ubuntu-latest
environment:
name: pypi
name: release-test
url: https://test.pypi.org/p/green
permissions:
id-token: write # IMPORTANT: this permission is mandatory for trusted publishing
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
if: github.event_name == 'release'
runs-on: ubuntu-latest
environment:
name: pypi
name: release
url: https://pypi.org/p/green
permissions:
id-token: write # IMPORTANT: this permission is mandatory for trusted publishing
Expand Down
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
#### Date TBD

# Version 4.0.1
#### 14 Feb 2024
#### 15 Feb 2024

Note that we are explicitly flagging Python 3.12.1 as incompatible due to a regression
that was fixed in 3.12.2.
Expand Down
4 changes: 2 additions & 2 deletions release.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,6 @@ Steps to Release

2. Push and merge to the main branch.

3. Trigger the Release Test workflow in GitHub Actions. Optional but recommended.
3. Trigger the Release Test workflow in GitHub Actions then approve the run on the release-test environment. Optional but recommended.

4. Create a new release in GitHub with a tag that mirrors the version, the GH action will take care of the rest.
4. Create a new release in GitHub with a tag that mirrors the version, the GH action will take care of the rest after beeing approved to run.