-
-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more typing to the codebase and various fixes. #285
Conversation
The coverage reports are broken somehow (reported as zero coverage), but only over GH Actions. Locally it seems to work fine either on macOS or through a Linux container:
I'll try to get that fixed as a separate issue. |
- ensure the Makefile will behave more consistently across machines by setting the shell to Bash. - update the coverage.py configuration in pyproject.toml to exclude `if TYPE_CHECKING:` blocks. - fix potential bugs in the loader. - fix default global kwargs dict in process.py.
targets = [targets] | ||
|
||
# Make sure there are no duplicate entries, preserving order | ||
target_dict = OrderedDict() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OrderedDict has more features but if they are not used, a regular dict is good enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM
if TYPE_CHECKING:
blocks.