Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

n3: deprecate addressTXFull #15

Merged
merged 3 commits into from
Oct 31, 2023
Merged

n3: deprecate addressTXFull #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8588e6b
n3: deprecate addressTXFull
ixje Feb 19, 2023
9144852
remove obsolete test
ixje Feb 19, 2023
9d5585b
trigger ci
ixje Oct 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/api/neo/rest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,9 @@ export class NeoRESTApi {
return await this.get(network, method, address, page)
}

/**
* @deprecated use addressTransactions instead
*/
async addressTXFull(
address: string,
page = 1,
Expand Down
14 changes: 1 addition & 13 deletions src/tests/api/neo/neo.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,18 +137,6 @@ describe('neo sdk', () => {
assert.strictEqual(res.items.length, 15)
})

// TODO: broken on API v1 side, v2 not yet implemented. Skip for now
// it('should get the enhanced transactions for an address', async () => {
// const res = await NeoRest.addressTransactions(
// 'Nb9QYTVx8F6j5kKi1k1ERaUTFfSX5JRq2D',
// 1
// )
// assert.isNotNull(res)
// assert.isObject(res)
// assert.isArray(res.items)
// assert.isAtLeast(res.items.length, 14)
// })

it('should get transfer history', async () => {
const res = await NeoRest.transferHistory(
'Nb9QYTVx8F6j5kKi1k1ERaUTFfSX5JRq2D',
Expand All @@ -174,7 +162,7 @@ describe('neo sdk', () => {
})

it('should get the full transactions history for an address', async () => {
const res = await NeoRest.addressTXFull(
const res = await NeoRest.addressTransactions(
'Nb9QYTVx8F6j5kKi1k1ERaUTFfSX5JRq2D',
1,
'testnet'
Expand Down