CU-86a5x0q43 - BS Swap - Bug - availableTokensToUse has tokens that d…

…o not have decimals
CityOfZion · Dec 14, 2024 · fa36e9a · fa36e9a
1 parent cdc79f4
commit fa36e9a
Show file tree

Hide file tree

Showing 3 changed files with 30 additions and 10 deletions.
diff --git a/common/changes/@cityofzion/bs-swap/CU-86a5x0q43_2024-12-14-01-53.json b/common/changes/@cityofzion/bs-swap/CU-86a5x0q43_2024-12-14-01-53.json
@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@cityofzion/bs-swap",
+      "comment": "Fix bug where availableTokensToUse has tokens that do not have decimals",
+      "type": "patch"
+    }
+  ],
+  "packageName": "@cityofzion/bs-swap"
+}
diff --git a/packages/bs-swap/src/apis/SimpleSwapApi.ts b/packages/bs-swap/src/apis/SimpleSwapApi.ts
@@ -10,6 +10,7 @@ import {
   SimpleSwapApiGetRangeResponse,
   SimpleSwapServiceInitParams,
 } from '../types/simpleSwap'
+import { Token } from '@cityofzion/blockchain-service'
 
 export class SimpleSwapApi<BSName extends string = string> {
   #axios: AxiosInstance
@@ -42,17 +43,23 @@ export class SimpleSwapApi<BSName extends string = string> {
     if (chainsByServiceNameEntry) {
       blockchain = chainsByServiceNameEntry[0]
 
-      if (!hash) {
-        const token = options.blockchainServicesByName[blockchain].tokens.find(
-          token => currency.ticker?.toLowerCase().startsWith(token.symbol.toLowerCase())
+      let token: Token | undefined
+
+      if (hash) {
+        token = options.blockchainServicesByName[blockchain].tokens.find(item => hash!.replace('0x', '') === item.hash)
+      }
+
+      if (!token) {
+        token = options.blockchainServicesByName[blockchain].tokens.find(
+          item => currency.ticker?.toLowerCase().startsWith(item.symbol.toLowerCase())
         )
+      }
 
-        if (token) {
-          hash = token.hash
-          decimals = token.decimals
-          name = token.name
-          symbol = token.symbol
-        }
+      if (token) {
+        hash = token.hash
+        decimals = token.decimals
+        name = token.name
+        symbol = token.symbol
       }
     }
 

diff --git a/packages/bs-swap/src/services/SimpleSwapService.ts b/packages/bs-swap/src/services/SimpleSwapService.ts
@@ -198,7 +198,10 @@ export class SimpleSwapService<BSName extends string = string> implements SwapSe
       blockchainServicesByName: this.#blockchainServicesByName,
       chainsByServiceName: this.#chainsByServiceName,
     })
-    this.#availableTokensToUse = { loading: false, value: tokens }
+
+    const filteredTokens = tokens.filter(token => token.blockchain && token.decimals && token.hash)
+
+    this.#availableTokensToUse = { loading: false, value: filteredTokens }
   }
 
   async setTokenToUse(token: SwapServiceToken<BSName> | null): Promise<void> {