Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: separate page queries #1602

Merged
merged 2 commits into from
Jan 23, 2025
Merged

refactor: separate page queries #1602

merged 2 commits into from
Jan 23, 2025

Conversation

joonatank
Copy link
Contributor

@joonatank joonatank commented Jan 12, 2025 •
edited by jira bot
Loading

🛠️ Changelog

  • Fix: missing tax percentage in ReservationInfoCard. customer
  • Refactor: all reservation queries to be page specific and use fragments (mostly based on components). customer
  • Refactor: move queries / fragments to the component / page they are used in.
  • Refactor: remove second SSR query from reservation funnel.

🧪 Test plan

  • Automation: e2e new / edit / cancel reservation should work as before.

🎫 Tickets

@joonatank joonatank requested a review from vincit-matu January 12, 2025 09:09
@joonatank joonatank force-pushed the fix-missing-tax-percentage branch 2 times, most recently from 87187cd to 3a062aa Compare January 13, 2025 03:05
@joonatank joonatank requested review from vergama and ranta January 15, 2025 13:47
@joonatank joonatank force-pushed the fix-missing-tax-percentage branch from 3a062aa to 579bc17 Compare January 16, 2025 14:08
@joonatank joonatank force-pushed the fix-missing-tax-percentage branch from 579bc17 to 67eedaa Compare January 20, 2025 09:30
@joonatank joonatank merged commit b9c6685 into main Jan 23, 2025
8 checks passed
@joonatank joonatank deleted the fix-missing-tax-percentage branch January 23, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vergama vergama vergama approved these changes

@vincit-matu vincit-matu Awaiting requested review from vincit-matu

@ranta ranta Awaiting requested review from ranta

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joonatank @vergama