Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add: missing breadcrumbs #1586

Merged
merged 2 commits into from
Jan 16, 2025
Merged

add: missing breadcrumbs #1586

merged 2 commits into from
Jan 16, 2025

Conversation

joonatank
Copy link
Contributor

@joonatank joonatank commented Dec 20, 2024 •
edited
Loading

🛠️ Changelog

  • Add: breadcrumbs to all pages except frontpage.
  • Fix: too large gap between links on confirmation page.
  • Fix: IconButton row being clickable when inside a flex container.
  • Refactor: breadcrumbs, simpler code and remove overrides ment for admin-ui reusability (not used anymore).
  • Refactor: remove old string breadcrumb, use explicit slug + title pairs instead.
  • Refactor: remove unnecessary wrapper.

🧪 Test plan

  • Manual testing: check the breadcrumbs are on all pages and work correctly (mobile / desktop).

🎫 Tickets

@joonatank joonatank force-pushed the add-missing-breadcrumbs branch 4 times, most recently from 127b448 to 9c0a853 Compare December 20, 2024 15:24
@joonatank joonatank marked this pull request as ready for review December 20, 2024 15:30
vincit-matu
vincit-matu approved these changes Jan 5, 2025
View reviewed changes
Copy link
Contributor

@vincit-matu vincit-matu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joonatank joonatank force-pushed the add-missing-breadcrumbs branch from 9c0a853 to 7e7da81 Compare January 8, 2025 13:45
@joonatank joonatank force-pushed the add-missing-breadcrumbs branch 2 times, most recently from 291e2b2 to 6717c7a Compare January 16, 2025 07:46
@joonatank joonatank force-pushed the add-missing-breadcrumbs branch from 6717c7a to e4b8a17 Compare January 16, 2025 10:05
@joonatank joonatank merged commit 5941af6 into main Jan 16, 2025
8 checks passed
@joonatank joonatank deleted the add-missing-breadcrumbs branch January 16, 2025 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincit-matu vincit-matu vincit-matu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joonatank @vincit-matu