Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't allow creation of empty series #1577

Merged
merged 1 commit into from
Jan 16, 2025
Merged

fix: don't allow creation of empty series #1577

merged 1 commit into from
Jan 16, 2025

Conversation

joonatank
Copy link
Contributor

🛠️ Changelog

  • Fix: don't allow creation / modification of series if they would end up with 0 resevations.

🧪 Test plan

  • Manual testing: problem reporting in slack. Try to create / change series so it would end up with 0 reservations.

🎫 Tickets

  • TILA-####

@joonatank joonatank force-pushed the fix-dont-allow-creating-empty-series branch from 6ac7a50 to faddce2 Compare January 8, 2025 13:03
@joonatank joonatank force-pushed the fix-dont-allow-creating-empty-series branch from faddce2 to cc22f12 Compare January 16, 2025 07:17
@joonatank joonatank mentioned this pull request Jan 16, 2025
Closed
@joonatank joonatank merged commit a49b5a0 into main Jan 16, 2025
16 checks passed
@joonatank joonatank deleted the fix-dont-allow-creating-empty-series branch January 16, 2025 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincit-matu vincit-matu vincit-matu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joonatank @vincit-matu