Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix slow search page #1557

Merged
merged 8 commits into from
Dec 16, 2024
Merged

Fix slow search page #1557

merged 8 commits into from
Dec 16, 2024

Conversation

joonatank
Copy link
Contributor

@joonatank joonatank commented Dec 3, 2024

🛠️ Changelog

  • Fix: changing language clears the search form.
  • Fix: single search page takes too long to navigate.
  • Fix: Card component over scaling on dekstop.
  • Fix: search form modifications (like sort / tag delete) scrolling the page to top.
  • Chore: remove deprecation warnings.
  • Chore: bump react and react-i18next.

🧪 Test plan

  • Manual testing: search page speed of load + functionality.
  • Manual testing: check that #content has tag (from front page link) scrolls correctly on mobile.

🎫 Tickets

@joonatank joonatank requested a review from vincit-matu December 3, 2024 16:24
@joonatank joonatank force-pushed the fix-slow-search-page branch 8 times, most recently from 734c02a to d8012c8 Compare December 4, 2024 09:25
Copy link
Contributor

@vincit-matu vincit-matu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@joonatank joonatank force-pushed the fix-slow-search-page branch from d8012c8 to 010539a Compare December 10, 2024 08:51
@joonatank joonatank force-pushed the fix-slow-search-page branch from 010539a to baad511 Compare December 10, 2024 08:55
@joonatank joonatank merged commit 1832667 into main Dec 16, 2024
8 checks passed
@joonatank joonatank deleted the fix-slow-search-page branch December 16, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants